feat: add replace_is_some_with_if_let_some assist #15743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Thanks! |
|
☀️ Test successful - checks-actions |
|
@HKalbasi hi, I'd like to add |
|
Do as you see fit. My weak preference is to have them in a single mod if they can share some code. |
Young-Flash
changed the title
bors
added a commit
that referenced
this pull request
Oct 13, 2023
…od, r=HKalbasi feat: add replace_is_ok_with_if_let_ok assist following #15743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic impl, if it is ok,
if my_result.is_ok()->if let Ok(_x) = my_result will be add next.close #12977